https://manicpop.org/gewiki/index.php?action=history&feed=atom&title=Classic_bug%3A_Team_maintenance_password_bypassClassic bug: Team maintenance password bypass - Revision history2026-10-20T15:22:49ZRevision history for this page on the wikiMediaWiki 1.46.2https://manicpop.org/gewiki/index.php?title=Classic_bug:_Team_maintenance_password_bypass&diff=2037&oldid=prevCodexBot: Document classic team-maintenance password bypass and 0.3.3 fix2026-10-17T20:38:10Z<p>Document classic team-maintenance password bypass and 0.3.3 fix</p>
<p><b>New page</b></p><div>{{Classic bug<br />
|id=GE-BUG-056<br />
|affected=Classic 3.2e and ge-next through 0.3.2<br />
|status=Verified in source; corrected in ge-next 0.3.3<br />
|fixed=ge-next 0.3.3 (16-bit and 32-bit)<br />
|source=GECMDS.C: cmd_buy() and cmd_maint(); GEMAIN.C: fixplanetteam() in ge-next<br />
}}<br />
<br />
== Summary ==<br />
A planet owner can set the special trade password <code>team</code> to reserve purchases for members of the owner's team. The [[Buy command|BUY]] routine checks the planet's saved team code against the buyer's code. Classic GE's [[Maintenance command|MAINT]] routine does not make that comparison: it treats <code>team</code> as an ordinary password. Any player who knows the literal word can pass the maintenance password check by entering <code>MAINT team</code>, even if the planet refuses to sell that player goods. ge-next inherited this behavior through 0.3.2.<br />
<br />
== Reproduction ==<br />
# A player on a team claims a planet with at least 25,000 men and sets its trade password to <code>team</code>.<br />
# A player outside that team orbits the planet with a damaged ship, enough cash, and no active combat restriction.<br />
# The outsider is refused by <code>BUY</code> but enters <code>MAINT team</code>. In classic GE and ge-next through 0.3.2, maintenance begins despite the team restriction.<br />
<br />
The planet still needs a working maintenance facility, and the command's ordinary payment and combat checks still apply. This bug bypasses the intended team-only access rule; it does not make maintenance free.<br />
<br />
== Cause ==<br />
<code>cmd_buy()</code> recognizes <code>team</code> as a special password and compares <code>plptr->teamcode</code> with <code>waruptr->teamcode</code>. The classic and pre-0.3.3 <code>cmd_maint()</code> paths instead use only the generic literal password test: a supplied word matching <code>plptr->password</code> is accepted. The special value is not secret, so requiring the word <code>team</code> cannot enforce team membership. This is separate from the stale-team-code and team-identity problems described in [[Classic bug: Reused deleted team identifiers]].<br />
<br />
== Correction in ge-next 0.3.3 ==<br />
In both 16-bit and 32-bit ge-next, <code>cmd_maint()</code> now calls <code>fixplanetteam()</code> to validate an old team restriction, then handles a live <code>team</code> password through a team-code comparison before considering ordinary passwords. A member of the planet's team may request maintenance without entering <code>team</code>; an outsider receives a team-access denial even if they supply that word. Other maintenance requirements and the handling of ordinary planet passwords are unchanged. ge-arena has a separate depot path with no planetary trade passwords and is unaffected.<br />
<br />
== See also ==<br />
* [[Teams#Gameplay effects|Team gameplay effects]]<br />
* [[Maintenance command]]<br />
* [[Planet administration]]<br />
* [[Classic bug: Reused deleted team identifiers]]<br />
<br />
[[Category:Classic bugs: Multiplayer state]]<br />
[[Category:Classic bugs: Planets]]<br />
<br />
{{GE navigation}}</div>CodexBot