Jump to content

Proposed changes for Elwynor

From Galactic Empire wiki
  • fix MAXPLSE off-by-one – MAXPLSE is the maximum amount of planets in a sector. By default this is 5, but an off-by-one issue in GEPLANET.C causes it to be one fewer. This fixes the issue and changes the default to 4 so there is no change in actual gameplay defaults.
  • warp rotation bounds check fix – When specifying a direction to rotate when using the warp command, if an out-of-bounds degree is entered (outside of -180 to 180), the "helm is damaged" error will show. This restructures the command to avoid that.
  • fix for cybs not pursing user on channel 0 – Once a game has loaded all NPCs, Cybertrons will not pursue a ship on user channel 0. Before a Cyb is dispatched to a ship, notclaimed() in GECYBS.C will check to see if this ship is already claimed ("cybmine") by the maximum amount of pursuers. However, since Droids do not set a cybmine value, they default to 0, and notclaimed() counts them. As such, Cybs will never claim this ship. This adds a specific Cyborg check to notclaimed() and adds a cybmine=255 to all new Droids, correcting the problem.
  • cyberbases should never move – Cyberbases should never move, but if you attack one and flee without destroying it, it will attempt to pursue using cyb_check_lockon(). Since its max_accel value is 0, it is unable to rotate. Therefore, it will set itself to a high warp speed, never find the ship it is attempting to pursue, and crash into the galactic barrier. This excludes all cybs with max_accel == 0 from movement routines.


MSG glow ups:

All of these clean up color codes so that the ending color of a message doesn't "bleed" into the prompt. It also uses specific bold/non-bold colors and ends every text box (that ends by returning to a prompt) with a bright white color code, so the game doesn't dim and brighten as you play. No spelling or grammar fixes (yet?), keeping close to the original.

  • ELWGEHLP glow up – in addition to color fixes: add a couple commands that were missing from the main help screen, removed a section about not being able to transfer up items from planets you own (this was changed in development), updated ships and item lists, fixed the scores in HLPSCORE, changed a detail in HLPMIS, fixed the mark-19 shield price (was apparently supposed to be 250M but prices are capped at 201288837), and a few other little things.
  • ELWGE.MSG glow up – in addition to color fixes: changed documentation to reflect ELW* files, removed the following unused relics: TPRCNT, NOFIRES, NOSCANS, NOSCANH, NOSCANL, NEWSHP1, NEWSHP2, LOWFOOD, OUTFOOD, TOPTEN1, TOPTEN2, SCAN17, SCAN17A, SCAN18, SCAN19, SCAN20, SCAN21, SCAN22, and SCAN23. (LOCK1, SCAN10A, SCAN26, and ADMIN05 are unused in 3.2e but are referenced in commented-out code so I left them for now. Same with CANTROT, it's not commented out but it's unreachable.)
  • ELWGESHP glow up – color fixes and HELP CLASS cleanup and corrections.